Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid-fall Nix and CI cleaning #380

Merged
merged 16 commits into from
Nov 12, 2024
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Aug 7, 2024

I nitpicked my own Nix
Call it nixpicking

We've also had Docker images failing to build a while because of rust-overlay being bumped to 1.80.0 and one of our deps not working for it yet it seems :/ FIXED!

We should change the required checks to the Clippy scan, "CI Release Gate", and "Docker Release" in the repo as to avoid things breaking again

@getchoo getchoo requested a review from Scrumplex August 7, 2024 04:12
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we build this using Nix anymore in CI? That is the main way I deploy refraction

@getchoo getchoo force-pushed the rust-1.80 branch 2 times, most recently from 02f5ee8 to 50dde10 Compare August 7, 2024 08:13
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@getchoo
Copy link
Member Author

getchoo commented Aug 7, 2024

Why don't we build this using Nix anymore in CI?

The main package has been added to checks with nix-fast-build building it now

@Scrumplex
Copy link
Member

I don't quite understand the usefulness of building on all three platforms supported by GH Actions, though. Seems quite wasteful for next to no gain.

@getchoo
Copy link
Member Author

getchoo commented Aug 7, 2024

I'm not a big fan of it either, but i've caught myself accidentally adding os-specific stuff from time to time (looking at you tokio). I don't know how else we can continuously make sure contributors are able to build locally otherwise

The only real option I see is dropping the regular rust linux build and just using Nix instead?

@getchoo getchoo changed the title End of summer Nix cleaning + Fix Docker builds against Rust 1.80 End of summer Nix cleaning Aug 21, 2024
@getchoo getchoo force-pushed the rust-1.80 branch 2 times, most recently from 1d1e122 to 7d954b7 Compare November 11, 2024 22:26
@getchoo getchoo changed the title End of summer Nix cleaning Mid-fall Nix and CI cleaning Nov 11, 2024
@getchoo
Copy link
Member Author

getchoo commented Nov 11, 2024

Only Linux and Windows are built now, as there shouldn't be anything Linux specific here, only Unix. We don't really need to worry about it in the Nix package either

@getchoo getchoo requested a review from Scrumplex November 11, 2024 22:56
@Scrumplex Scrumplex merged commit 163898a into PrismLauncher:main Nov 12, 2024
10 checks passed
@getchoo getchoo deleted the rust-1.80 branch November 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants